[VLAN] spin lock question

[Stephen Hemminger]

On Fri, 06 Oct 2006 09:48:27 +0100
Alex Zeffertt <ajz at cambridgebroadband.com> wrote:

> Hi list,
> 
> I've been reading through the 8021q.o module source recently and
> I am confused by the choice of spin lock used in the following
> code:
> 
> 
> int vlan_skb_recv(struct sk_buff *skb, struct net_device *dev,
>                    struct packet_type* ptype)
> {
> 	...
> 	spin_lock_bh(&vlan_group_lock);
> 	skb->dev = __find_vlan_dev(dev, vid);
> 	if (!skb->dev) {
> 		spin_unlock_bh(&vlan_group_lock);
> 	...
> 

That code should use RCU actually.

-- 
Stephen Hemminger <shemminger at osdl.org>